Add configurable body streaming iterator for APPSEC #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add get_body_iterator() function that streams request bodies in chunks - Support both in-memory and temp file bodies - Add APPSEC_BODY_CHUNK_SIZE configuration (default 8KB, range 8KB-64KB) - Remove HTTP/2/3 early return check (Content-Length inferred from headers/body) - Add header_number() helper to handle table headers - Stream bodies to APPSEC to reduce memory usage and improve timeout handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is if the body is buffered to a temporary file we can stream chunk it from the file to request instead of bringing the whole file into memory. For smaller bodies this does not improve the memory usage.