Updates for Spree 3.x and Fix #43 crowdint/spree_conekta#43#44
Open
mvidaurre wants to merge 31 commits intocrowdint:masterfrom
Open
Updates for Spree 3.x and Fix #43 crowdint/spree_conekta#43#44mvidaurre wants to merge 31 commits intocrowdint:masterfrom
mvidaurre wants to merge 31 commits intocrowdint:masterfrom
Conversation
…787 drop credit_cards first_name and last_name fields The credit card decorator was redefining name based on name_on_card or first_name and last_name. Because in Spree master first_name and last_name were drop and redefined using name this then was causing an “Stack too deep” error
…_just_completed? method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long pull request. With several modifications for taking in consideration changes in Spree 3.x