Modify pipeline and layout creation to preserve original createInfo if modified by addons#415
Open
MohannedElfatih wants to merge 2 commits into
Open
Modify pipeline and layout creation to preserve original createInfo if modified by addons#415MohannedElfatih wants to merge 2 commits into
MohannedElfatih wants to merge 2 commits into
Conversation
68f995f to
546f50c
Compare
Owner
|
I'm generally not opposed to something like this, similar stuff is already done elsewhere (e.g. D3D12 root signature creation gets original flags passed through in since they don't translate well). Need to disect the code a bit though =P |
ea559ef to
d9d771a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any modifications to pipelines/layouts can cause unexpected errors because it forces it to go through internal functions instead of trampoline. I attempted to modify on top of the original createInfo instead of throwing it all together.
The changes are too extensive (& AI generated obviously) but it's more as a proof of concept to increase reshade's robustness. Please feel free to close it if it doesn't fit reshade's intended approach.