Skip to content

Modify pipeline and layout creation to preserve original createInfo if modified by addons#415

Open
MohannedElfatih wants to merge 2 commits into
crosire:mainfrom
MohannedElfatih:pipeline-rework
Open

Modify pipeline and layout creation to preserve original createInfo if modified by addons#415
MohannedElfatih wants to merge 2 commits into
crosire:mainfrom
MohannedElfatih:pipeline-rework

Conversation

@MohannedElfatih
Copy link
Copy Markdown
Contributor

Any modifications to pipelines/layouts can cause unexpected errors because it forces it to go through internal functions instead of trampoline. I attempted to modify on top of the original createInfo instead of throwing it all together.

The changes are too extensive (& AI generated obviously) but it's more as a proof of concept to increase reshade's robustness. Please feel free to close it if it doesn't fit reshade's intended approach.

@crosire
Copy link
Copy Markdown
Owner

crosire commented Apr 23, 2026

I'm generally not opposed to something like this, similar stuff is already done elsewhere (e.g. D3D12 root signature creation gets original flags passed through in since they don't translate well). Need to disect the code a bit though =P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants