Skip to content

fix: Slack::sendExec always returns true #7

Description

@dacgray

Relevance

When testing on Shop API the method sometimes works, sometimes fails for an unknown reason.

Fire and forget should not mean we should ignore errors. We always return true on sendExec, so we hide failed sends.

Proposal

  • get $output
  • determine pass/fiail
  • return bool on success

Specifics

The response looks something like:

image.png

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions