Skip to content

Chore: Use SPDX. Update verlib2. #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amotl wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

Chore: Use SPDX. Update verlib2. #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be6fe5
Chore: Update project metadata to use SPDX license identifier
amotl May 10, 2025
dc67045
Dependencies: Update to verlib2>=0.3
amotl May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ description = "CrateDB Python Client"
authors = [{ name = "Crate.io", email = "[email protected]" }]
requires-python = ">=3.10"
readme = "README.rst"
license = { file = "LICENSE"}
license = "Apache-2.0"
license_files = ["LICENSE"]
Copy link
Member

@seut seut Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://packaging.python.org/en/latest/guides/licensing-examples-and-user-scenarios/ there is no need to explicitly define license_files or license_file?

Suggested change
license_files = ["LICENSE"]

classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
Expand Down
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Copy link
Member Author

@amotl amotl Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setup.py can be removed soon?

Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,15 @@ def read(path):
long_description=long_description,
long_description_content_type="text/x-rst",
platforms=["any"],
license="Apache License 2.0",
license="Apache-2.0",
license_files=["LICENSE"],
keywords="cratedb db api dbapi database sql http rdbms olap",
packages=find_namespace_packages("src"),
package_dir={"": "src"},
install_requires=[
"orjson<4",
"urllib3",
"verlib2",
"verlib2>=0.3",
],
extras_require={
"doc": [
Expand All @@ -82,7 +83,6 @@ def read(path):
classifiers=[
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
Expand Down