Skip to content

[5.6] Sanitising query input from element index actions #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfourtythree merged 9 commits into from
Feb 18, 2026
+117 −80
Merged

[5.6] Sanitising query input from element index actions #4232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e6e6e8
Fix injection from element indexes
nfourtythree Feb 16, 2026
a329fbb
remove typo
nfourtythree Feb 16, 2026
6dac511
Tidy implementation of `cleanseQueryCriteria()`
nfourtythree Feb 16, 2026
d71b995
Merge branch '5.6' into bugfix/sql-injection-from-element-indexes
nfourtythree Feb 16, 2026
24b28e6
Fix cs
nfourtythree Feb 16, 2026
640c2eb
Bump Craft requirement to 5.9.9+
nfourtythree Feb 16, 2026
21ed7d7
Tweak changelogs
nfourtythree Feb 16, 2026
d92c9e0
Merge branch '5.6' into bugfix/sql-injection-from-element-indexes
nfourtythree Feb 18, 2026
8482e0e
rector fix
nfourtythree Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions CHANGELOG-WIP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
# WIP Release notes for Commerce 5.6

### Development
- Cart controller actions that accept an explicit cart number are now rate limited to mitigate enumeration attacks.
- Cart numbers are now generated using a cryptographically secure random number generator.
- Fixed a bug where Variant with empty SKUs didn't show a validation error when saving a product after it was duplicated. ([#4197](https://github.com/craftcms/commerce/issues/4197))
- Shipping rule categories are now eager loaded on shipping rules automatically. ([#4220](https://github.com/craftcms/commerce/issues/4220))
- Added `craft\commerce\services\ShippingRuleCategories::getShippingRuleCategoriesByRuleIds()`.
- Added `variantUiLabelFormat` and `productUiLabelFormat` settings to product types, for customizing how products and variants are labeled throughout the control panel. ([#4178](https://github.com/craftcms/commerce/pull/4178))
- Added `relatedToProducts` and `relatedToVariants` GraphQL query arguments, enabling queries for elements related to specific products or variants. ([#4202](https://github.com/craftcms/commerce/discussions/4202))

### Extensibility
- Added `craft\commerce\elements\db\ProductQuery::$savable`.
- Added `craft\commerce\elements\db\ProductQuery::savable()`.
- Added `craft\commerce\elements\db\VariantQuery::$savable`.
- Added `craft\commerce\elements\db\VariantQuery::savable()`.
- Added `craft\commerce\elements\db\VariantQuery::editable()`.
- Added `craft\commerce\elements\db\VariantQuery::savable()`.
- Added `craft\commerce\helpers\ProductQuery::cleanseQueryCriteria()`.
- Added `craft\commerce\services\ShippingRuleCategories::getShippingRuleCategoriesByRuleIds()`.
- Added `craft\commerce\services\ShippingRuleCategories::getShippingRuleCategoriesByRuleIds()`.
- Added `relatedToProducts` and `relatedToVariants` GraphQL query arguments, enabling queries for elements related to specific products or variants. ([#4202](https://github.com/craftcms/commerce/discussions/4202))
- Added `variantUiLabelFormat` and `productUiLabelFormat` settings to product types, for customizing how products and variants are labeled throughout the control panel. ([#4178](https://github.com/craftcms/commerce/pull/4178))
- `craft\commerce\elements\db\ProductQuery::$editable` is now nullable.
- `craft\commerce\elements\db\VariantQuery::$editable` is now nullable.

### System
- Craft Commerce now requires Craft CMS 5.9.9 or later.
- Fixed a bug where Variant with empty SKUs didn't show a validation error when saving a product after it was duplicated. ([#4197](https://github.com/craftcms/commerce/issues/4197))
- Fixed a SQL error that could occur when querying for unfulfilled orders on PostgreSQL. ([#4228](https://github.com/craftcms/commerce/issues/4228))
- Fixed an error that could occur when resaving variants. ([#4226](https://github.com/craftcms/commerce/issues/4226))
- Fixed [high-severity](https://github.com/craftcms/cms/security/policy#severity--remediation) SQL injection vulnerabilities in the control panel.
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
- Fixed an error that could occur when editing inventory locations. ([#4233](https://github.com/craftcms/commerce/issues/4233))
- Fixed a SQL error that could occur when querying for unfulfilled orders on PostgreSQL. ([#4228](https://github.com/craftcms/commerce/issues/4228))
- Fixed an error that could occur when resaving variants. ([#4226](https://github.com/craftcms/commerce/issues/4226))
- Fixed [high-severity](https://github.com/craftcms/cms/security/policy#severity--remediation) SQL injection vulnerabilities in the control panel.
- Added `craft\commerce\helpers\ProductQuery::cleanseQueryCriteria()`.

## 5.5.3 - 2026-02-09

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"prefer-stable": true,
"require": {
"php": "^8.2",
"craftcms/cms": "^5.9.0",
"craftcms/cms": "^5.9.9",
"dompdf/dompdf": "^2.0.2",
"ibericode/vat": "^1.2.2",
"iio/libmergepdf": "^4.0",
Expand Down
Loading
Loading