fix(affiliate): dune caching & error repoting & linting

[kernelwhisperer]

Please ignore the branch name.

Summary

• The cache is not working right now because it was per request, to make it app wide we need .inSingletonScope()
• Error reporting syntax was wrong making victoria logs less useful (missing error object)
• Integrate prettier into eslint so that fixOnSave works in vs code
• PR with autofix chore: run yarn lint:fix #217

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes add a comprehensive Jest test suite for the Inversify container factory, export the getApiContainer function for external access, update AffiliateStatsService to use singleton scope ensuring a single shared instance, reduce the affiliate stats cache TTL from 1 hour to 5 minutes, and modify error logging in two route handlers to use structured logging format.

Changes

Cohort / File(s)	Summary
Inversify Container Configuration apps/api/src/app/inversify.config.ts	Exports getApiContainer function, applies inSingletonScope() to AffiliateStatsService binding for single instance reuse, and reduces cache TTL default from 1 hour to 5 minutes.
Inversify Container Tests apps/api/src/app/inversify.config.spec.ts	New comprehensive test suite for getApiContainer with mocked repositories and services, verifies singleton scope behavior of AffiliateStatsService, validates cache TTL environment variable parsing, and confirms dependency injection correctness.
Affiliate Route Error Logging apps/api/src/app/routes/affiliate/affiliate-stats/_address/index.ts, apps/api/src/app/routes/affiliate/trader-stats/_address/index.ts	Updates error logging in catch blocks from positional argument to structured field format ({ err: error }) for consistent log payload shape.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 The container now sings with singleton grace,
One service instance in its stable place,
TTLs tick faster, logs structured and clear,
With tests watching closely—no bugs will appear!
A rabbit's delight: dependency injection done right! 🌰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title addresses multiple changes: singleton caching for AffiliateStatsService, updated cache TTL default, structured error logging in affiliate routes, and exporting getApiContainer—all present in the changeset.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/affiliate-trader-activity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

apps/api/src/app/inversify.config.ts (2)

77-93: Double-check the new default TTL.

Dropping the fallback from 1 hour to 5 minutes is a 12x increase in cache churn and upstream Dune calls. If that freshness improvement is intentional, fine; otherwise keep the longer default and rely on the env override for shorter-lived environments.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/api/src/app/inversify.config.ts` around lines 77 - 93, The default cache
TTL was reduced to 5 minutes which increases upstream Dune calls; revert the
DEFAULT_AFFILIATE_STATS_CACHE_TTL_MS to the original 1 hour (3600*1000 ms) in
the file and keep the getAffiliateStatsCacheTtlMs() logic and
DUNE_AFFILIATE_STATS_CACHE_TTL_MS env override unchanged so environments can
still opt into shorter TTLs if desired.

---

96-228: Avoid two public container entry points unless both are intentional.

getApiContainer() creates a fresh Container, while apiContainer remains a module-level singleton. Any runtime caller that switches to the factory will get a separate AffiliateStatsService cache, so the new singleton scope becomes container-local rather than process-wide. If the factory is only for tests, keep it internal; otherwise document that callers must share one container instance.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/api/src/app/inversify.config.ts` around lines 96 - 228, The module
currently exposes two public entry points (getApiContainer and apiContainer)
causing services bound with inSingletonScope (e.g., AffiliateStatsService bound
via affiliateStatsServiceSymbol with inSingletonScope) to become container-local
rather than process-wide; fix by making a single public container: either make
getApiContainer non-exported (keep only the module-level apiContainer export) or
remove the apiContainer export and document/export only the factory and ensure
callers share its instance; update usages/tests to obtain the same container
(use apiContainer or call a single exported factory wrapper) so
AffiliateStatsService and other singletons remain process-wide.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/api/src/app/inversify.config.ts`:
- Around line 77-93: The default cache TTL was reduced to 5 minutes which
increases upstream Dune calls; revert the DEFAULT_AFFILIATE_STATS_CACHE_TTL_MS
to the original 1 hour (3600*1000 ms) in the file and keep the
getAffiliateStatsCacheTtlMs() logic and DUNE_AFFILIATE_STATS_CACHE_TTL_MS env
override unchanged so environments can still opt into shorter TTLs if desired.
- Around line 96-228: The module currently exposes two public entry points
(getApiContainer and apiContainer) causing services bound with inSingletonScope
(e.g., AffiliateStatsService bound via affiliateStatsServiceSymbol with
inSingletonScope) to become container-local rather than process-wide; fix by
making a single public container: either make getApiContainer non-exported (keep
only the module-level apiContainer export) or remove the apiContainer export and
document/export only the factory and ensure callers share its instance; update
usages/tests to obtain the same container (use apiContainer or call a single
exported factory wrapper) so AffiliateStatsService and other singletons remain
process-wide.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d78e598-adfe-4476-a266-893c7ad48013

📥 Commits

Reviewing files that changed from the base of the PR and between 6a9c693 and 6732502.

📒 Files selected for processing (4)

• apps/api/src/app/inversify.config.spec.ts
• apps/api/src/app/inversify.config.ts
• apps/api/src/app/routes/affiliate/affiliate-stats/_address/index.ts
• apps/api/src/app/routes/affiliate/trader-stats/_address/index.ts

[kernelwhisperer]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	pg@​8.13.1
	eslint-plugin-prettier@​4.2.5

View full report

[Danziger]

Not urgent, but if both the previous version and the new one are correct, but behave differently, maybe we should create a util function so that we don't make this mistake again?