Saving Strip Pairing Chi Square for Each Detector#121
Open
julianmgerber wants to merge 2 commits intocositools:develop/emfrom
Open
Saving Strip Pairing Chi Square for Each Detector#121julianmgerber wants to merge 2 commits intocositools:develop/emfrom
julianmgerber wants to merge 2 commits intocositools:develop/emfrom
Conversation
ckierans
reviewed
Apr 13, 2026
Collaborator
ckierans
left a comment
There was a problem hiding this comment.
Looks good, Julian. Just make sure this vector is being saved to the EVTA file so it can be filtered in mimrec.
| for (auto i : m_StripPairingReducedChiSquare) { | ||
| S<<" "<<i; | ||
| } | ||
| S<<endl; |
Collaborator
There was a problem hiding this comment.
You only have the streaming defined for the .dat file, but we also will want this in the evta file - that's the standard format for revan. This should probably be incorporated in the StreamBDFlags function where you already have the Strip Pairing quality flag printout. Unless there's a reason you had this pulled out separately?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes: