move away from numpy.fix in favor of numpy.trunc#450
Closed
hellerve wants to merge 1 commit into
Closed
Conversation
ejolly
added a commit
to ejolly/nltools
that referenced
this pull request
Apr 22, 2026
Mirrors cosanlab#450 applied on the refactored path (nltools/stats/timeseries.py in 0.6.0, was nltools/stats.py on master). Co-authored-by: Veit Heller <veit@veitheller.de>
Collaborator
|
Hi @hellerve — thanks for the patch and the deprecation context. Closing here because I'm preparing a 0.6.0 rewrite in #453 that substantially refactors Credit preserved in the git log. Apologies for the extra step. |
ejolly
added a commit
to ejolly/nltools
that referenced
this pull request
Apr 22, 2026
Mirrors cosanlab#450 applied on the refactored path (nltools/stats/timeseries.py in 0.6.0, was nltools/stats.py on master). Co-authored-by: Veit Heller <veit@veitheller.de>
Author
|
No worries. No credit needed, but thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of
numpy.fixwithnumpy.trunc. This is in response to a currently discussed deprecation ofnumpy.fixas well as performance considerations (nice, but secondary).This change should not change anything in a meaningful way, internally or externally.
Cheers