Skip to content

feat: add WithContext versions of all functions - #38

Merged
mikemrm merged 1 commit into
mainfrom
mrm/gofish-ctx
Aug 7, 2026
Merged

feat: add WithContext versions of all functions#38
mikemrm merged 1 commit into
mainfrom
mrm/gofish-ctx

Conversation

@mikemrm

@mikemrm mikemrm commented Aug 6, 2026

Copy link
Copy Markdown

This adds *WithContext versions of every api client method, removing the need to clone the api client to provide a different context.

For the most part, every functions which uses the context directly or passes the api client and later uses the context have been updated to have *WithContext versions and instead pass the context provided. All original methods were updated to use the new context method by passing in the cached context.

This change is a non-breaking change except for the fact that the api client interface has gained all the WithContext methods. Other than that, all existing method signatures were unaffected.

@mikemrm
mikemrm marked this pull request as ready for review August 6, 2026 18:03
@mikemrm
mikemrm merged commit 70c692c into main Aug 7, 2026
0 of 2 checks passed
@mikemrm
mikemrm deleted the mrm/gofish-ctx branch August 7, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants