Skip to content

promote a bunch of hidden fields - #34

Merged
joeyberkovitz merged 2 commits into
mainfrom
manager-links
Jul 16, 2026
Merged

promote a bunch of hidden fields#34
joeyberkovitz merged 2 commits into
mainfrom
manager-links

Conversation

@joeyberkovitz

Copy link
Copy Markdown

promotes a bunch of private members on Manager to public

this is a bit breaking since some members ended up dup'ed as a result

}

// ResetMetrics resets time intervals or counted values of the diagnostic data for this manager.
func (manager *Manager) ResetMetrics() error {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would've been a nasty bug if anyone used it

Comment thread redfish/manager.go
SupportedResetTypes []ResetType
resetToDefaultsTarget string
resetToDefaultsActionInfoTarget string
SupportedResetToDefaultsTypes []ResetToDefaultsType

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// resetInfo contains URI for an ActionInfo Resource that describes this action.
actionInfo string
// SupportedResetTypes, if provided, is the reset types this system supports.
SupportedResetTypes []ResetType

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// firmware images that apply to this manager.
softwareImages []string
// SoftwareImagesCount is the number of firmware images that apply to this manager.
SoftwareImagesCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// resources of which this Manager instance has control.
managerForSwitches []string
// ManagerForSwitchesCount is the number of Switches being managed.
ManagerForSwitchesCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// resources of which this Manager instance has control.
managerForServers []string
// ManagerForServersCount is the number of Servers being managed.
ManagerForServersCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// being managed by this manager.
managerForManagers []string
// ManagerForManagersCount is the number of managers being managed by this manager.
ManagerForManagersCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// resources of which this Manager instance has control.
managerForChassis []string
// ManagerForChassisCount is the number of Chassis being managed.
ManagerForChassisCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// manager.
managedBy []string
// ManagedByCount is the number of managers for this manager.
ManagedByCount int

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// Oem are all OEM data under top level manager section
Oem json.RawMessage
// OEMLinks are all OEM data under link section
OemLinks json.RawMessage

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

Comment thread redfish/manager.go
// manager.
networkProtocol string
// OemActions contains all the vendor specific actions. It is vendor responsibility to parse this field accordingly
OemActions json.RawMessage

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking

@joeyberkovitz
joeyberkovitz merged commit 82c5f4f into main Jul 16, 2026
2 checks passed
@joeyberkovitz
joeyberkovitz deleted the manager-links branch July 16, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants