This repository was archived by the owner on Mar 28, 2020. It is now read-only.
Add tmpfs option for etcd-data volume#2103
Open
chriscoester wants to merge 1 commit intocoreos:masterfrom
Open
Add tmpfs option for etcd-data volume#2103chriscoester wants to merge 1 commit intocoreos:masterfrom
chriscoester wants to merge 1 commit intocoreos:masterfrom
Conversation
|
Any chance someone could look into this? Anything I can do to help with getting it in? |
Marlinc
approved these changes
Nov 9, 2019
Marlinc
suggested changes
Nov 9, 2019
| k8sutil.AddEtcdVolumeToPod(pod, pvc, false) | ||
| } else { | ||
| k8sutil.AddEtcdVolumeToPod(pod, nil) | ||
| k8sutil.AddEtcdVolumeToPod(pod, nil, c.cluster.Spec.Pod.Tmpfs) |
There was a problem hiding this comment.
I have tested this and it will cause the operator to crash with a nil error when c.cluster.Spec.Pod is nil.
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an additional optional field to the etcdcluster.spec.pod field, allowing etcdpods to use tmpfs for etcd-data.
Fixes #2053