fw/services/hrm: drop events when subscriber queue is full#1377
Merged
Conversation
hrm_manager_new_data_cb asserted that every HRM sample was delivered to every subscriber via PBL_ASSERTN(prv_event_put(...)). For an app/worker subscriber, prv_event_put uses xQueueSendToBack() with a zero timeout, so it returns false the instant the app's event queue is full. A subscribed app that fails to drain its event queue fast enough therefore panicked the whole firmware (observed as an assert at prv_populate_hrm_event in a coredump, due to the noreturn assert's return address landing in the next inlined block). Drop the sample and bump dropped_events instead of asserting, mirroring the existing behavior for the KernelBG circular buffer. The zero timeout is kept on purpose: the callback holds s_manager_state.lock, so blocking here would risk deadlock/watchdog. The expiring-subscription event now only sets sent_expiration_event on success so it is retried rather than lost. Re-enable test_hrm_manager (it builds and passes) and add a regression test covering the full-queue drop path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
jplexer
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hrm_manager_new_data_cb asserted that every HRM sample was delivered to every subscriber via PBL_ASSERTN(prv_event_put(...)). For an app/worker subscriber, prv_event_put uses xQueueSendToBack() with a zero timeout, so it returns false the instant the app's event queue is full. A subscribed app that fails to drain its event queue fast enough therefore panicked the whole firmware (observed as an assert at prv_populate_hrm_event in a coredump, due to the noreturn assert's return address landing in the next inlined block).
Drop the sample and bump dropped_events instead of asserting, mirroring the existing behavior for the KernelBG circular buffer. The zero timeout is kept on purpose: the callback holds s_manager_state.lock, so blocking here would risk deadlock/watchdog. The expiring-subscription event now only sets sent_expiration_event on success so it is retried rather than lost.
Re-enable test_hrm_manager (it builds and passes) and add a regression test covering the full-queue drop path.