fw/services/alarms: add sound playback with selectable tones#1259
fw/services/alarms: add sound playback with selectable tones#1259spr4bhu wants to merge 6 commits into
Conversation
Please no! |
is the no for default being sound + vibration or is there something else too? |
Sound being on by default (just my opinion here!) |
sure, that can be changed also can you pretty please take a look at pr #1156 and lmk how are features to be added in the mobile app |
|
@jplexer ping |
|
Agree to keep sound off as default for newly created alarms. Whole reason why I use alarms on pebble is the lack of sound. |
wanted to wait until sound-off was the default |
|
Sound off by default. Not going to change the current behavior |
|
Are these settings exposed and configurable on mobile too? |
|
The settings are only visible on the watch rn Is there a any format you have to move the features from watch to mobileapp ? |
|
The sound is now turned off by default |
gmarull
left a comment
There was a problem hiding this comment.
there seem to be some intermediate changes that are later removed, please, squash content accordingly so only the final solution is reflected. We do not merge unfinished/broken stuff.
53b3d69 to
99edfda
Compare
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
Signed-off-by: Shashvat Prabhu <shashvatprabhu2006@gmail.com>
99edfda to
7b6bcb2
Compare
|
should be fixed now, lmk if any other changes required |
|
thanks, this looks quite nice! would you be okay with me making one change (specifically to make reveille fit the vibration pattern haha) |
|
sure go ahead |
|
Continuing work on #1357 tysm for the PR! |
This PR adds audio playback to alarms on speaker-capable hardware (Pebble 2 Duo, Pebble Time 2). Each alarm has independent sound and vibration toggles plus a selectable tone (Reveille, Beacon, Bell, Chime). Off by default for existing alarms; new alarms on speaker hardware default to sound + vibration on.
Changes:
sound_enabled,vibrate_enabled,tonefields toAlarmConfig, bit-packed into the existingis_smartunion no struct size change. Negative-logicvibrate_disabledbit chosen so legacy data (all bits 0) loads as vibrate-on, sound-off, preserving current behavior on upgrade.alarm_toneslibrary (src/fw/services/alarms/alarm_tones.c) with 4 in-codeSpeakerNote[]arrays. No resource files needed.speaker_service_play_note_seqintoalarm_popup.catSpeakerPriorityCritical, looping via the speaker finish event until dismiss/snooze/timeout. Skipped in low-power mode.alarm_detail.cwith a Sound submenu (Off + 4 tones) and a Vibration toggle, mirroring the existing snooze-delay pattern.alarm_idtoPebbleAlarmClockEventso the popup can look up the firing alarm's settings.CAPABILITY_HAS_SPEAKER; non-speaker boards are unaffected.Resolves #1206