Repository navigation
Conversation
The site had no logo and no favicon — DocumenterVitepress warned about both
on every build. Add them from the winning design in
`.extras/logos/logo-gagnant/`:
- `docs/src/assets/logo.png` (1200×1200, copied verbatim)
- `docs/src/assets/favicon.ico` (multi-resolution 64/48/32/16, derived)
`CairoMakie` and `Colors` join `docs/Project.toml` so the logo page
(next commit) can generate the figure for real with the Makie backend —
pinned `0.15` / `0.13` to match the `CT*Makie` extensions' own compat.
`docs/src/assets/{Manifest,Project}.toml` regenerated in the same commit,
per the standing rule.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New page `examples/logo.md`: the OptimalControl.jl logo is an energy-minimal low-thrust orbit transfer, solved once and rotated ±120° into the three Julia-logo dots. One linear `@example` session — the transfer problem in `@def`, a warm-started `solve` with the insertion residuals, `Makie.plot(sol)`, the (x₁,x₂) spiral, then the three-fold rotation into the finished figure, which matches the committed `logo.png`. Points at `.extras/logos/logo-gagnant/` for the exact asset script. This is also the docs' first page to use the Makie plotting backend. `make.jl`: "The logo" appended to the Examples nav. Verified: full docs build exit 0, 0 unresolved @ref, the two DocumenterVitepress "No logo.png / No favicon.ico" warnings gone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Suite au retrait de Correction en une ligne (retirer la clause « and, downscaled, as its favicon »), à traiter dans une petite PR de suivi ou à plier dans E6 (suppression de |
ocots
added a commit
that referenced
this pull request
Aug 31, 2026
The favicon was removed before #921 merged (the site keeps the default DocumenterVitepress favicon), but the page still said the figure was used "downscaled, as its favicon". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Corrigé directement sur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The site had no logo and no favicon — DocumenterVitepress warned about both on every build. This adds them, and a page that explains what the logo actually is: an optimal control problem.
The OptimalControl.jl logo is an energy-minimal low-thrust orbit transfer — a spacecraft spiralling from a low circular orbit out to a higher one under continuous weak thrust. Solved once and rotated by ±120°, the three trajectories' departure points land as the three dots of the Julia logo, winding onto the outer orbit around the central body.
Commits
Assets + deps —
logo.png(1200×1200, copied verbatim from.extras/logos/logo-gagnant/) andfavicon.ico(multi-resolution, derived).CairoMakie+Colorsjoindocs/Project.toml, pinned0.15/0.13to match theCT*Makieextensions' own compat.docs/src/assets/{Manifest,Project}.tomlregenerated in the same commit per the standing rule.The page —
examples/logo.md, one linear executed@examplesession:@def(normalised two-body dynamics, three insertion conditions,∫‖u‖² → min)solve+ the insertion residualsMakie.plot(sol)— the docs' first page to use the Makie plotting backend(x₁, x₂)spirallogo.png.extras/logos/logo-gagnant/for the exact asset scriptNo
Transfer/Layoutstructs, no trait dispatch — the generator in.extrasstays the reference render; the page is a worked example, not a script.Decision recorded
CairoMakiein the docs env (decision B in.reports/campaign/K-logo.md): the page runs the real thing and generates the published asset, at the cost of ~a few hundred MB and ~4 min of CI precompile. This is the docs' first Makie usage — ahead of the dedicated Makie-doc phase, but self-contained and not in conflict.Verification
Full
julia --project=. docs/make.jl:Cannot resolve @refDocumenterVitepress: No logo.png / No favicon.icowarnings gonedocs/src/assets/logo.png@extrefupstream-backlog itemsAdd the
run documentationlabel to build the site in CI.🤖 Generated with Claude Code