chore: tighten compat bounds to the newest that resolves (Phase F) - #900
Merged
Merged
Conversation
Seven [compat] entries still listed two versions each, even though every one already resolves to the newer of the two on a free resolve — the older lane is a fallback nobody's CI exercises. Motivated by MadNLPGPU = "0.8, 0.10": up to 0.8, CUDSS was a hard dependency and the GPU extension armed by accident; from 0.9 it's weak and must be loaded explicitly, so keeping both in range meant the documentation had to describe two different worlds for the same package. Decided in .reports/campaign/decisions.md §1. CUDA "5, 6" -> "6" DiffEqBase "6, 7" -> "7" CUDSS "0.6, 0.7, 0.8" -> "0.7" ForwardDiff "0.10, 1" -> "1" MadNLP "0.9, 0.10" -> "0.10" OrdinaryDiffEq "6, 7" -> "7" MadNLPGPU "0.8, 0.10" -> "0.10" docs/Project.toml mirrors the five of these seven it carries (no CUDSS, no DiffEqBase entry there). CUDSS tightens to "0.7", not "0.8", specifically in this repository: traced the mechanism precisely this time — LinearSolve carries a weak-compat ceiling on CUDSS (WeakCompat.toml: ["3.80 - 5"] CUDSS = "0.7"), and this repo's NonlinearSolve 4 pulls in a LinearSolve inside that exact bracket. CTSolvers/CTDirect don't depend on NonlinearSolve, so they aren't capped the same way and can go to 0.8. No behaviour change: every bound tightens onto the version already being resolved. No public API change. Verified: - Both environments resolve cleanly; the 7 targets land where expected (CUDA 6.2.0/6.3.1, CUDSS 0.7.0, DiffEqBase 7.20.0, ForwardDiff 1.4.5, MadNLP 0.10.1, MadNLPGPU 0.10.2, OrdinaryDiffEq 7.8.1). - Full test suite: 2246 pass, 0 fail, 2 broken (the two deliberate GPU skips) — unchanged from before the tightening. - Docs build clean; unresolved @ref unchanged at 6. - docs/src/assets/{Manifest,Project}.toml regenerated per the standing rule (decisions.md §2/F15): whenever a compat bound moves, the tracked snapshot is refreshed in the same PR. Confirmed the OptimalControl self-entry Phase A/#899 removed stays removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven
[compat]entries listed two versions each, though every one already resolves to thenewer of the two on a free resolve — the older lane is a fallback nobody's CI exercises.
Motivated by
MadNLPGPU = "0.8, 0.10": up to 0.8,CUDSSwas a hard dependency and the GPUextension armed by accident; from 0.9 it's weak and must be loaded explicitly, so keeping both
in range meant the documentation had to describe two different worlds for the same package.
Decided in
decisions.md§1.CUDA"5, 6""6"CUDSS"0.6, 0.7, 0.8""0.7"— not"0.8", see belowDiffEqBase"6, 7""7"ForwardDiff"0.10, 1""1"MadNLP"0.9, 0.10""0.10"MadNLPGPU"0.8, 0.10""0.10"OrdinaryDiffEq"6, 7""7"docs/Project.tomlmirrors the five of these it carries (noCUDSS, noDiffEqBaseentrythere).
Why CUDSS tightens to 0.7, not 0.8, specifically here
Traced the mechanism precisely:
CUDSSitself declares noLinearSolvecompat at all — theconstraint runs the other way. LinearSolve carries a weak-compat ceiling on CUDSS
(
LinearSolve/WeakCompat.toml:["3.80 - 5"] CUDSS = "0.7"), and this repository'sNonlinearSolve 4pulls in aLinearSolveinside that exact bracket.CTSolvers/CTDirectdon't depend on
NonlinearSolve, so they aren't capped the same way and can (and do) go toCUDSS = "0.8".Compatibility
No behaviour change — every bound tightens onto the version already being resolved.
No public API change.
Verification
CUDA6.2.0/6.3.1,CUDSS0.7.0,DiffEqBase7.20.0,ForwardDiff1.4.5,MadNLP0.10.1,MadNLPGPU0.10.2,OrdinaryDiffEq7.8.1.to before the tightening.
@refunchanged at 6.docs/src/assets/{Manifest,Project}.tomlregenerated per the standing rule(
decisions.md§2 / F15): whenever a compat bound moves, the tracked snapshot is refreshedin the same PR. Confirmed the
OptimalControlself-entry docs: remove the seven passages three upstream fixes made false (Phase G) #899 removed stays removed — thisPR does not reintroduce it.
Out of scope
.reports/campaign/F-compat-tighten.md.🤖 Generated with Claude Code