test: freeze plotting reference matrix + free-final-time fixture#362
Merged
Conversation
Transcribe the .extras/ visual-check scripts into an executable reference matrix (test_plot_reference.jl) covering the gaps left by test_plot.jl: description subsets, per-group :none styles, decoration disabling, user styles (color/label/NamedTuple), plot! overlays, and normalized time. Add solution_example_free_final_time: a free-final-time fixture (double integrator minimum time) built via the functional CTModels API (variable! before time!(...; indf=1)). This exercises the time-decoration path that reads tf from the decision variable, completing the reference matrix without a CTDirect/Ipopt test dependency. All 203 extension tests pass; full suite green (Aqua included). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transcribe the
.extras/visual-check scripts into an executable reference matrix that freezes the plotting behaviour for phase 0 (spec & gel) of the plotting-engine unification. Two components:test_plot_reference.jl (72 assertions) — covers the gaps left by test_plot.jl:
*_style=:noneend-to-end (5 groups + combos)time_style,*_bounds_style…)plot!overlays + normalized timesolution_example_free_final_time — new fixture, double integrator minimum time:
tfis a decision variable)final_time(model, variable(sol))path that no fixed-time fixture coversTest Results
Impact
Non-breaking change to test/ only. The reference matrix is the foundation for phase 1 (CTBase engine + CTBasePlots renderer): golden assertions on the IR will be added when that phase begins.
🤖 Generated with Claude Code