CI on windows - #512
Merged
Merged
Conversation
relpath returns backslash-separated paths on Windows, which silently broke every glob-based test selection (including the default "suite/*/test_*") since patterns are always written with forward slashes — resulting in 0 tests being collected and CI reporting a false green. Add a CI job that dry-runs test selection with and without arguments on windows-latest/ubuntu-latest to catch this class of regression going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…er fix Also make the new test-selection-smoke CI job robust to a Windows-only Pkg.test quirk: after a cold precompile, julia can exit non-zero after already printing "tests passed" with no error output, which pipefail was turning into a false failure of the smoke job. Judge success from the dry-run listing content instead of julia's raw exit code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sed -n '/^Dry run:/,$p' captured everything to end of file, including Pkg's own trailing "Testing CTBase tests passed" status line printed after run_tests returns. That extra line inflated the "no selection" count by one (harmless there) but broke the "suite/data" prefix check, since it doesn't start with "suite/data/". Match "^suite/" directly instead, which only ever matches real test paths. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.