Fix: user subplot/plot attributes now reach the cells in CTBasePlots#483
Merged
Conversation
Split user kwargs into series attributes (color, linewidth, label, …) and subplot attributes (legend, grid, framestyle, …). Previously only series attributes were kept, so legend/grid were silently dropped. User legend/ylims now override IR defaults. - ext/CTBasePlots.jl: _partition_user replaces _keep_series_attributes - test/suite/plotting/test_contract.jl: add test for legend override - CHANGELOGS.md: v0.27.2-beta entry - Project.toml: bump to 0.27.2-beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split user kwargs into series attributes (color, linewidth, label, …) and subplot attributes (legend, grid, framestyle, …). Previously only series attributes were kept, so legend/grid were silently dropped. User legend/ylims now override IR defaults.
Changes:
ext/CTBasePlots.jl:_partition_userreplaces_keep_series_attributestest/suite/plotting/test_contract.jl: add test for legend overrideCHANGELOGS.md: v0.27.2-beta entryProject.toml: bump to 0.27.2-beta