Conversation
Reject http(s) URLs whose host resolves to a private, loopback, or link-local address before favicon or content fetch runs, using the existing is-localhost-ip helper. Keeps agent Read URL / fetchUrlContent from SSRF-shaped egress to RFC1918 and cloud metadata addresses. Fixes continuedev#13310 Signed-off-by: GokayAI <60583610+gokay-ai@users.noreply.github.com>
gokay-ai
requested review from
sestinj
and
a balanced review from Copilot
and removed request for
a team
September 29, 2026 06:26
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Signed-off-by: GokayAI <60583610+gokay-ai@users.noreply.github.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: GokayAI <60583610+gokay-ai@users.noreply.github.com>
Signed-off-by: GokayAI <60583610+gokay-ai@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getUrlContextItems/fetchUrlContentfetched arbitrary URLs with no private-IP check. This addsassertPublicHttpUrl(via the existingis-localhost-iphelper) so private, loopback, and link-local destinations are rejected before favicon or content fetch.Fixes #13310
Testing
cd core npx vitest run util/assertPublicUrl.vitest.ts context/providers/URLContextProvider.vitest.ts tools/implementations/fetchUrlContent.vitest.tsAll 10 tests passed locally.
Notes
allowPrivateNetworkcan be separate if useful.