[develop] add create_snapshot() interface #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a live snapshot feature for overlaybd with the following key capabilities: - Add HTTP API server (/snapshot endpoint) for creating snapshots on demand - Implement create_snapshot() to dynamically restack RW layers - Add device ID tracking system for image file management - Support config_path;dev_id format in configuration strings - Extend LSMT layer management with restack(), index manipulation, and file operations - Add comprehensive tests for restacking, device registration, and snapshot creation Co-authored-by: Xun Chen <[email protected]> Co-authored-by: Yifan Yuan <[email protected]> Signed-off-by: Yifan Yuan <[email protected]>
Add documentation for the live snapshot feature including: - serviceConfig configuration options - Device ID format and usage - HTTP API endpoint (/snapshot) - New config format requirements - Usage examples and notes Signed-off-by: Yifan Yuan <[email protected]>
Member
Author
|
@WaberZhuang @liulanzheng PTAL |
WaberZhuang
suggested changes
Feb 10, 2026
| photon::net::http::Response& resp, | ||
| std::string_view) override; | ||
| void parse_params(std::string_view query); | ||
| }; |
Contributor
There was a problem hiding this comment.
I think it's not necessary to expose ApiHandler in the header file. It's okay to just pass ImageService* to ApiServer.
There was a problem hiding this comment.
Are you suggesting that I should define ApiHandler in the cpp file instead of the header, and then instantiate it inside the ApiServer constructor?
| auto pos = target.find('?'); | ||
| if (pos != std::string_view::npos) { | ||
| query = target.substr(pos + 1); | ||
| } |
Contributor
There was a problem hiding this comment.
Use req.query() instead.
| } | ||
|
|
||
| auto upper = new_cfg.upper(); | ||
| auto lowers = new_cfg.lowers(); |
| ((LSMT::IFileRO *)m_lower_file)->index(combo_index->backing_index()); | ||
| // set m_file->m_index->m_index0 = upper_file->m_index | ||
| auto upper_file_index = (LSMT::IMemoryIndex0 *)((LSMT::IFileRW *)upper_file)->index(); // upper_file->m_index | ||
| combo_index->front_index(upper_file_index); |
Contributor
There was a problem hiding this comment.
Should we overwrite the config file in use at this time? Otherwise, the old files will be used again after the process restarts.
liulanzheng
reviewed
Feb 11, 2026
| virtual int front_index(const IMemoryIndex0 *fi) override { | ||
| if (!fi) { | ||
| errno = EINVAL; | ||
| LOG_ERROR("Invalid index!"); |
liulanzheng
reviewed
Feb 11, 2026
| } | ||
| if (m_ownership && m_index0 != nullptr) { // !!! | ||
| delete m_index0; | ||
| m_index0 = nullptr; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add online snapshot functionality to overlaybd.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: