feat: two-day supply-chain quarantine in scaffolded workspaces - #41
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #40 — same shape as that PR (a
pnpm-policy.yamlper template, the generated block inpnpm-workspace.yaml,policy/policy:checkscripts, and a CI drift check), with the wait cut from 14 days to 2 and no README prose.Two days is where the tradeoff sits for a scaffold: a hijacked account or typosquat is normally caught and yanked within hours to a day, so the wait still removes the sharp edge, while nobody is blocked for a fortnight from taking a legitimate release.
allowBuildsandexceptionsare empty but present, commented with the shape of an entry, so approving a native build or waiving the wait for a same-day security fix is a two-line edit pluspnpm run policy— and anuntil:on a waiver makespolicy:checkfail rather than let it live forever.One rough edge: nothing is locked on the very first install, so it resolves every version fresh and trips on anything younger than the wait (including
pnpm-policyitself right after a release).pnpm install --config.minimumReleaseAge=0once gets past it; after the lockfile is committed, installs replay it and the wait only applies to versions being added.Verified by scaffolding
pnpm/workspaceinto a temp dir: first install with the escape flag, thenpolicy:checkreports a match, then--frozen-lockfilere-installs clean.Link to Devin session: https://app.devin.ai/sessions/ffa3b012deac4eb7afb8f49a9af9f9ca
Requested by: @pyramation