Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/actions/setup-kind/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,20 @@ inputs:
kind_version:
description: kind version, without the leading v
required: false
# What helm/kind-action@v1.12.0 installed, so this changes nothing but the
# way it is fetched.
default: '0.26.0'
default: '0.30.0'
node_image:
description: >
kindest/node image to boot. Pinned (with digest) rather than left to the
kind binary's default: what Kubernetes the cluster serves is part of what
the suites test — Knative v1.22+ refuses to start below Kubernetes 1.34
("Version check failed", crash-loop), which an unpinned default hid as a
CI-only webhook timeout (constructive-planning#1630).
required: false
default: 'kindest/node:v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a'
kubectl_version:
description: kubectl version
required: false
default: v1.31.3
default: v1.34.1
config:
description: Optional path to a kind cluster config
required: false
Expand Down Expand Up @@ -69,7 +76,7 @@ runs:
shell: bash
run: |
set -euo pipefail
args=(--name "${{ inputs.cluster_name }}" --wait "${{ inputs.wait }}")
args=(--name "${{ inputs.cluster_name }}" --wait "${{ inputs.wait }}" --image "${{ inputs.node_image }}")
[ -n "${{ inputs.config }}" ] && args+=(--config "${{ inputs.config }}")
kind create cluster "${args[@]}"
kubectl cluster-info
4 changes: 2 additions & 2 deletions .github/workflows/regenerate-ops.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Setup kubectl
uses: azure/setup-kubectl@v3
with:
version: v1.31.3
version: v1.34.1

- name: Setup Helm
uses: azure/setup-helm@v4
Expand All @@ -79,7 +79,7 @@ jobs:
uses: ./.github/actions/setup-kind
with:
cluster_name: ops-codegen
kubectl_version: v1.31.3
kubectl_version: v1.34.1
wait: 300s

# Applied from the package, not from URLs. Every operator it vendors is
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ jobs:
- name: Setup kubectl
uses: azure/setup-kubectl@v3
with:
version: v1.31.3
version: v1.34.1

- name: Setup Kind cluster
if: ${{ inputs.kubeconfig == '' }}
uses: ./.github/actions/setup-kind
with:
cluster_name: kind
kubectl_version: v1.31.3
kubectl_version: v1.34.1
wait: 300s

- name: Setup pnpm
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-e2e-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ jobs:
- name: Setup kubectl
uses: azure/setup-kubectl@v3
with:
version: v1.31.3
version: v1.34.1

- name: Setup Kind cluster
uses: ./.github/actions/setup-kind
with:
cluster_name: kind
kubectl_version: v1.31.3
kubectl_version: v1.34.1
wait: 300s

- name: Setup pnpm
Expand Down Expand Up @@ -104,13 +104,13 @@ jobs:
- name: Setup kubectl
uses: azure/setup-kubectl@v3
with:
version: v1.31.3
version: v1.34.1

- name: Setup Kind cluster
uses: ./.github/actions/setup-kind
with:
cluster_name: kind
kubectl_version: v1.31.3
kubectl_version: v1.34.1
wait: 300s

- name: Setup pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e-dashboard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup kubectl
uses: azure/setup-kubectl@v3
with:
version: v1.31.3
version: v1.34.1

- name: Setup pnpm
uses: pnpm/action-setup@v2
Expand Down
9 changes: 1 addition & 8 deletions packages/client/__tests__/e2e/e2e.setup.operator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,7 @@ const K8S_API = process.env.K8S_API || "http://127.0.0.1:8001";
// default for a test: adding a version downstream would silently change what
// this suite installs, and a suite whose subject moves without anyone choosing
// it is not testing what its name says.
//
// knative-serving is pinned to v1.15.0 because v1.22.1 fails this suite in a
// way that does not reproduce by hand — see constructive-planning#1630. That is
// an apply-path problem to fix on its own, not a reason to hold the package
// back from carrying the version downstream needs.
const PINNED_VERSIONS: Record<string, string> = {
'knative-serving': 'v1.15.0',
};
const PINNED_VERSIONS: Record<string, string> = {};

function versionFor(name: string): string {
const versions = getOperatorVersions(name);
Expand Down
Loading
Loading