fix(pnpm-policy): generate before the first install - #111
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A freshly scaffolded workspace could not run
pnpm-policy generate:intersectdefaults totrue, soload()always readpnpm-lock.yamland died with "No pnpm-lock.yaml … Run pnpm install first" — before a lockfile exists. But intersection only narrows individual inventory names; a config withscopes:and noinventory:has none to narrow, so the read was gratuitous.This is what lets
pgpm init workspaceship a policy that generates andchecks on a clean checkout (constructive-io/pgpm-boilerplates#5).Also fixes a wrong generated comment in the same case — with no inventory the file claimed "First-party membership comes from the inventory" when it in fact comes from the
scopes:the config claims.Link to Devin session: https://app.devin.ai/sessions/ffa3b012deac4eb7afb8f49a9af9f9ca
Requested by: @pyramation