fix(pnpm-policy): invoke the CLI by path in the refresh workflow - #110
Merged
Conversation
pnpm resolves a workspace dependency to its publishConfig.directory only if that directory exists when the link is made. The tool is built after install, so on a fresh checkout the linked bin points at a cli.js that does not exist and the job dies with "Command pnpm-policy not found".
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second failure of the refresh workflow (run): the build step passes now, and the next one dies with
ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "pnpm-policy" not found.pnpm resolves a workspace dependency to its
publishConfig.directoryonly if that directory exists when the link is made.pnpm-policyhas"bin": "cli.js"relative todist/, anddist/is created by the build step — which runs after install. So on a fresh checkout the bin link points atpackages/pnpm-policy/cli.js, which does not exist. It works on a developer machine only becausedist/is usually already there from a previous build, which is exactly why this did not show up locally.Same reasoning for the package's
refreshscript, which had the same latent dependency on a link made before the build.Reproduced and verified locally under CI conditions (
rm -rfthe threedist/dirs andnode_modules/of the data package, thenpnpm install --frozen-lockfile): the old form fails with the identical error, the new form queries npm and rewrites the inventory. The resulting diff isgeneratedAt-only, so the workflow's suppression branch correctly declines to open a PR — also checked by running that condition against the real diff.Link to Devin session: https://app.devin.ai/sessions/ffa3b012deac4eb7afb8f49a9af9f9ca
Requested by: @pyramation