feat: macOS-style rounded app icon, generated like constructive-desktop - #8
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The icon looked square because it was full-bleed art. constructive-desktop rounds theirs by clipping the art to the standard macOS tile inside the SVG itself —
<clipPath><rect x=100 y=100 width=824 height=824 rx=185/></clipPath>on a transparent 1024 canvas — then regenerating the raster formats from it.Same setup here:
resources/icon.svgnow wraps the cube art in that clip, and a newpnpm iconsscript (scripts/generate-icons.mjs, sharp + png2icons — the exact script constructive-desktop uses) regeneratesresources/icon.{png,icns,ico}. The.icns/.icoare new, ready for future packaging.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation