feat: bulk JSON import for one-time codes; honour stored digits/period - #10
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds bulk import of authenticator JSON exports (
[{ name, secret, uri }, ...]) to the Codes tab, and fixes code generation for non-default entries.parseTotpJsonExport(json)insrc/shared/totp-import.ts: prefers each entry'sotpauth://URI (it carries digits/period/algorithm); falls back toname+secretas a default 6-digit/30s entry. Throws on malformed files, per-entry failures are reported individually.totp.importUriIPC and toasts a summary.digits=7&period=10) previously generated wrong codes —totpImportUrinever storeddigits, and bothVaultService.totpEntryanddcrypt vault totphardcoded{ period: 30, digits: 6 }. Both now read the storedperiod/digitsfields:Desktop tests (17) and CLI tests (30) pass; build + lint clean.
Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation