Skip to content

feat(node-type-registry): add DataInheritFromParent, DataForceCurrentUser, DataImmutableFields - #899

Merged
pyramation merged 1 commit into
mainfrom
devin/1774503925-add-new-data-node-types
Mar 26, 2026
Merged

pyramation merged 1 commit into
mainfrom
devin/1774503925-add-new-data-node-types

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Adds 3 new Data* node type definitions to the node-type-registry TS package, syncing with the entries recently added to constructive-db seed.sql:

  • DataInheritFromParent — BEFORE INSERT trigger that copies fields from a parent table via FK lookup (used by storage module)
  • DataForceCurrentUser — BEFORE INSERT trigger that forces a field to current_user_id() to prevent identity spoofing
  • DataImmutableFields — BEFORE UPDATE trigger that prevents changes to specified fields after INSERT

Each file follows the existing pattern (typed NodeTypeDefinition export with name, slug, category, description, parameter_schema, tags). The data/index.ts barrel re-exports all three.

Review & Testing Checklist for Human

  • Spot-check that parameter_schema in each new .ts file matches the corresponding entry in constructive-db seed.sql (fields, required arrays, descriptions, defaults) — these were manually transcribed
  • Verify DataForceCurrentUser intentionally has no required array (the only param field_name has a default of "actor_id")

Notes

  • Build passes locally (pnpm build clean)
  • Purely additive — no changes to existing files besides 3 new export lines in data/index.ts

Link to Devin session: https://app.devin.ai/sessions/ce1b2dafd42341bea5d7793b0c05ba6c
Requested by: @pyramation

…User, DataImmutableFields

Syncs the TS package with the 3 new Data* node types added to
constructive-db seed.sql: DataInheritFromParent (copies fields from
parent via FK), DataForceCurrentUser (forces current_user_id on insert),
DataImmutableFields (prevents field changes after insert).
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation
pyramation merged commit 098dc7d into main Mar 26, 2026
43 checks passed
@pyramation
pyramation deleted the devin/1774503925-add-new-data-node-types branch March 26, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant