chore: remove Knative jobs runtime - #1448
Merged
Merged
Conversation
Remove the repo-local jobs runtime packages and their wiring; job scheduling now lives in constructive-db. Keeps the JobTrigger blueprint node (node-type-registry) and the shared jobs config types. - Delete all jobs/* packages (worker, scheduler, service, fn, server, example, job-pg, job-utils, knative-job-worker) + 'jobs/*' workspace glob - Remove the 'cnc jobs' CLI command and its help text - Drop @constructive-io/knative-job-service dep from packages/cli - Remove docker-compose.jobs.yml and the knative-job-fn ambient decl - Drop jobs/knative-job-service from the pg-core CI test batch - Update CLAUDE.md/AGENTS.md workspace docs
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The jobs runtime that consumed this config was removed; constructive-db runs jobs with its own config, so this block is dead in this repo. - Delete pgpm/types/src/jobs.ts + its export - Drop the jobs field/default from PgpmOptions (pgpm.ts) and ConstructiveOptions (graphql/types/constructive.ts) - Remove JOBS_*/INTERNAL_GATEWAY/INTERNAL_JOBS_CALLBACK env parsing and the jobs.gateway production-safety asserts (pgpm/env) - Drop jobs cases from env merge/assert tests; re-record env snapshots
Resolve docker-compose.jobs.yml conflict by keeping the deletion (jobs runtime removed; file modified on main by #1445 no longer applies).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this removes the repo-local Knative jobs runtime AND the now-vestigial jobs config schema. Straight deletion — no behavior is reimplemented here.
1. Jobs runtime (commit 1)
jobs/*packages (job-pg,job-utils,job-scheduler,job-worker,knative-job-fn,knative-job-server,knative-job-service,knative-job-worker,knative-job-example) + the- 'jobs/*'glob inpnpm-workspace.yaml.cnc jobsCLI command (packages/cli/src/commands/jobs.ts), its entry in the command map, and its help text.@constructive-io/knative-job-servicedependency frompackages/cli.docker-compose.jobs.ymland the@constructive-io/knative-job-fnambient module decl intypes/external-modules.d.ts.jobs/knative-job-servicefrom thepg-coreCI test batch.CLAUDE.md/AGENTS.md.2. Jobs config schema (commit 2)
Confirmed unused by constructive-db (it runs jobs with its own
functions/packages + config, and doesn't import@pgpmjs/typesat all), so the config block was dead in this repo:pgpm/types/src/jobs.ts(JobsConfig/jobsDefaults+ theJob*Config/*JobParamstypes) and itsexport.jobsfield/default fromPgpmOptions(pgpm/types/src/pgpm.ts) andConstructiveOptions(graphql/types/src/constructive.ts).JOBS_*/INTERNAL_GATEWAY_URL/INTERNAL_JOBS_CALLBACK_*env parsing and thejobs.gateway.*production-safety asserts frompgpm/env.pgpm/env+graphql/envmerge snapshots (the"jobs": {…}block is gone).Deliberately kept (per @pyramation — schema-modeling, not runtime)
JobTriggerblueprint node and everything underpackages/node-type-registry(it declares triggers that callapp_jobs.add_job(); it does not run jobs).Verification
pnpm install(workspace 113→104 projects),pnpm build:dev— green.pgpm/env(26) +graphql/env(9) +packages/clitests pass; snapshots re-recorded.JOBS_SCHEMAhits left are generic sample keys inpackages/12factor-env's own parser tests, unrelated to jobs).Follow-up
Removal recorded on planning issue #1252 (commit SHA
783fda96) so constructive-db parity can be diffed against this revision. Also flagged there: constructive-db'sfunctions/job-workercurrently imports the published@constructive-io/job-utils(published from this repo) — it needs its own jobs/job-utils package rather than depending on constructive's published one.Link to Devin session: https://app.devin.ai/sessions/7f3cb2f4bf1147d6a97b30fd9aa56236