fix(policies): bind the capability picker to the array parameters - #19
Merged
Conversation
The published node-type-registry replaced the scalar permission parameter with levels[] and capabilities[], so the override key permission no longer matched a parameter the platform accepts while the parameters it does accept fell through to the plain multi-value editor.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#18 renamed the widget but not the parameter it writes to. The published
node-type-registry(1.15.0) changed the authz nodes' shape:POLICY_PROVISIONING_CONFIGandPOLICY_TYPE_UI_CONFIGboth still keyed their override onpermission, onAuthzEntityMembership,AuthzAppMembershipandAuthzRelatedEntityMembership. Net effect: the capability picker wrote a parameter the platform no longer accepts, whilecapabilities/levelsfell through to the generic multi-value editor, so an operator typed capability names by hand.paramOf(...)?.permission?.descriptionwasundefinedfor the same reason.Each of those three overrides becomes two, and
capability-selectbecomes multi-valued (MultiSelect) with alevel-selectsibling:Both are backed by one
useCapabilities()catalog, split onkind— which this PR also starts selecting, since the schema-builder copy of the hook never asked for it:That split is the point: trust-ladder levels share the capability bitstring but are not operator-grantable, so a level appearing in the capability picker (as it did before the rename exposed
kind) let an operator gate an RLS policy on an achievement. Now a level is selectable only as a level.pnpm checkpasses. Needs a@constructive-io/data+@constructive-io/schema-builderpublish before dashboard can mirror it.Link to Devin session: https://app.devin.ai/sessions/8f89acc9280e4cef880921d966e0e8fc
Requested by: @pyramation