Repository navigation
feat(tui): interactive TUI enhancements — drill-down, disk visualization, bug fixes - #2
Merged
Merged
Conversation
On macOS, temp directories go through /var which is a symlink to /private/var. jwalk fails to walk the unresolved path, returning 0.
Users can now select individual files/subdirs inside the drill-down view and delete them with d → y. Adds checkboxes, Space/a toggles, and a ConfirmDrillDown flow that trashes selected entries and rescans.
Running all recognizers in parallel via rayon's par_iter caused file descriptor exhaustion — each recognizer uses jwalk (also rayon-based) for dir_size, and the combined concurrent directory walking exceeded the OS open-file limit. Failed reads were silently swallowed by .filter_map(|e| e.ok()), causing dir_size to return 0 and findings to be randomly dropped. Switches to sequential iteration. The scan is I/O-bound so parallel recognizers provided no real speedup. Also removes the direct rayon dependency (jwalk still uses it internally).
…e size bars Add a disk summary header showing total/used/free space with a color-coded gauge bar (green <70%, yellow 70-85%, red >85%) and live reclaimable/selected counters. Add proportional inline size bars to both results and drill-down views, normalized to the largest item in each list. Closes #2
connectwithprakash
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tuias a default feature sodiskard -iworks without--features tuidir_sizeon macOS by canonicalizing symlinked pathsTest plan
cargo install --path .installs with TUI supportdiskard -ilaunches interactive mode with disk summary headerl/→enters drill-down; size bars normalize to largest entry in current directorydin drill-down deletes checked items and rescanscargo test— all 35 tests passcargo clippy --all-targets— no warnings