Fixes sensor data flow error into HA#11
Open
jeremyjed wants to merge 4 commits into
Open
Conversation
Fixes four bugs in the main repo. Referenced issue: conallob#9
updated files to fix authentication errors
Additional bugs were found around sensor data not flowing correctly to HA. The updated files fixes this and all sensors are showing accurate in HA
fixes sensor flow data to HA
|
Hi @jeremyjed, thanks for your contribution! I haven't used this integration yet but just received a U1 and just started looking at connecting it to HA. It's nice to see some active development around it. Reviewing the changes, it appears you may have made copies of the files from |
Owner
|
The unittests also need to pass in order for me to review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four additional bugs were found with sensor data not flowing into HA. Updated #9 to reflect these.