Added basic import structure for library usage#390
Conversation
|
Well, one second - it's behaving a bit oddly in kernel ATM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 91.81% 91.83% +0.01%
==========================================
Files 15 15
Lines 1112 1114 +2
Branches 138 138
==========================================
+ Hits 1021 1023 +2
Misses 69 69
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Exposes a minimal public API surface for the con_duct package by re-exporting the main execution entrypoint and explicitly defining module exports.
Changes:
- Re-export
executefromduct_mainat the package root (con_duct.execute). - Add
__all__to explicitly define the intended public exports (execute,__version__).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@asmacdo OK good to go - just note that |
asmacdo
left a comment
There was a problem hiding this comment.
@CodyCBakerPhD IMO this looks good, but I'm wondering if we've restricted it enough. Should the other files (ie cli ls json_utils, plot, pprint_json) also be made private for now? I'll go ahead and merge, but I suspect we should do a followup and perhaps reopen #389
|
@asmacdo So, this back to how strictly you want to follow convention Technically, anything not included in the scoped init of this PR should be marked private (both modules and internal methods / classes / globals) But as it is, the scope hides them well enough since they are not directly imported by the I think the VSCode completion is more sensitive to folder existence than PyCharm or ipython are so that would be the exception I think |
fix #389
@asmacdo Here you go