Opaque types, named constants, QeResult in Nbp.scala#99
Merged
Conversation
- State: remove 5 defaults, all 6 fields explicit - QeResult named type replaces (State, Double) tuple from executeQe - updateRate: prevRate/inflation → Rate, returns Rate - bondYield: refRate → Rate, nfa → PLN, returns Rate, no default on credibilityPremium - shouldActivateQe/shouldTaperQe: params → Rate - executeQe: bankBondHoldings/annualGdp → PLN, returns QeResult - 7 named constants extracted (OutputGapCap, DebtThreshold, FiscalRiskCap, QeCompressionCoeff, ForeignDemandDiscount, QeActivationSlack, QeDeflationThreshold)
Eliminates duplicated smoothing/clamping logic between symmetric and asymmetric Taylor branches. Each function is < 15 lines and independently testable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
State: removed 5 defaults — all 6 fields explicitQeResultnamed type replaces(State, Double)tuple fromexecuteQeupdateRate:prevRate/inflation→Rate, returnsRatebondYield:refRate→Rate,nfa→PLN, returnsRate, removed default oncredibilityPremiumshouldActivateQe/shouldTaperQe: params →RateexecuteQe:bankBondHoldings/annualGdp→PLN, returnsQeResultOutputGapCap,DebtThreshold,FiscalRiskCap,QeCompressionCoeff,ForeignDemandDiscount,QeActivationSlack,QeDeflationThreshold)Pure refactoring, no behavioral changes.
Test plan
sbt test— 1245 tests passvar, zero field defaults in Nbp.scala