This repository was archived by the owner on Mar 12, 2026. It is now read-only.
Opaque types, named constants, no defaults in Nbfi.scala#98
Merged
Conversation
- State: remove 7 defaults, all 13 fields explicit - zero: def → val in object State companion - initial: remove redundant PLN wrapping - step: wage/domesticCons → PLN, unempRate/bankNplRatio → Ratio, yields/returns/depositRate → Rate - Helper methods: bankTightness(Ratio)→Ratio, tfiInflow → PLN, nbfiOrigination/Repayment/Defaults take PLN/Ratio, return PLN - Extract 6 named constants (NplTightnessFloor/Range, UnempDefaultThreshold, ExcessReturnSens/Cap, MonthsPerYear) - Tests: mkStep helper, opaque type assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
State: removed 7 defaults — all 13 fields explicitzero:def→valinobject Statecompanioninitial: removed redundantPLN(x.toDouble)wrappingstep:wage/domesticCons→PLN,unempRate/bankNplRatio→Ratio, yields/returns/depositRate →RatebankTightness(Ratio) → Ratio,tfiInflow → PLN,nbfiOrigination/Repayment/DefaultstakePLN/Ratio, returnPLNNplTightnessFloor,NplTightnessRange,UnempDefaultThreshold,ExcessReturnSens,ExcessReturnCap,MonthsPerYear)mkStephelper, opaque type assertions throughout5 files, −129/+193. Pure refactoring, no behavioral changes.
Test plan
sbt test— 1245 tests passvar, zero field defaults in Nbfi.scala