This repository was archived by the owner on Mar 12, 2026. It is now read-only.
Jst StepResult, FxInterventionResult PLN, BankRates Vector[Rate]#100
Merged
Jst StepResult, FxInterventionResult PLN, BankRates Vector[Rate]#100
Conversation
…ctor[Rate] Jst.scala: - step params Double → PLN, remove pitRevenue default - (State, Double) return → StepResult named type - @param Scaladoc → inline comments - Extract FallbackPitRate constant Nbp.scala: - FxInterventionResult: eurTraded/newReserves → PLN Household.scala: - BankRates: Array[Double] → Vector[Rate]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three consistency fixes across
sfc.agents:Jst.scala:
stepparamsDouble→PLN(govTaxRevenue,totalWageIncome,gdp,pitRevenue)pitRevenuedefault — all callers explicit(State, Double)return →StepResultnamed type@paramScaladoc → inline commentsFallbackPitRate = 0.12constantNbp.scala:
FxInterventionResult.eurTraded/.newReserves:Double→PLNHousehold.scala:
BankRates:Array[Double]→Vector[Rate]for bothlendingRatesanddepositRates12 files, −108/+108 (zero net). Pure refactoring, no behavioral changes.
Test plan
sbt test— 1245 tests pass