Make ray imports in nn_utils optional - #39
Merged
rogerwwww merged 1 commit intoSep 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nn_utils/init.py star-imports tune_utils and base_hyperopt, which both import Ray. Because ms_pred.common imports nn_utils, Ray is needed to import almost anything in the package, including ICEBERG for inference, even though only the hyperparameter search uses it.
This change skips those two imports when Ray isn't installed. Any other import error is still raised as before, and nothing changes if Ray is installed.
We tested this in an environment without Ray: import ms_pred.nn_utils fails on main and works with this change.