Fix workflow run Open in IDE path#2003
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a ChangesWorkflow run CWD override for chat header
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Open in IDEinstead of the workflow run worktree.run.working_pathintoChatInterface, and the chat header prefers that explicit path when building the IDE-open target.UX Journey
Before
After
Architecture Diagram
Before
After
Connection inventory (list every module-to-module edge, mark changes):
WorkflowExecutionworking_pathfield is reused.WorkflowExecutionChatInterfacecwdOverride={workingPath}for DAG Chat tab.ChatInterfacechat-headerChatInterfaceHeaderLabel Snapshot
risk: lowsize: XSwebweb:workflow-executionChange Metadata
bugwebLinked Issue
Validation Evidence (required)
Commands and result summary:
bun test packages/web/src/lib/chat-header.test.ts bun --filter @archon/web type-check bun x prettier --check packages/web/src/components/chat/ChatInterface.tsx packages/web/src/components/workflows/WorkflowExecution.tsx packages/web/src/lib/chat-header.ts packages/web/src/lib/chat-header.test.ts bun x eslint packages/web/src/components/chat/ChatInterface.tsx packages/web/src/components/workflows/WorkflowExecution.tsx packages/web/src/lib/chat-header.ts --max-warnings 0 bun run validatebun run validatepassed in a clean worktree based onupstream/dev.Open in IDElaunches an external application; behavior is covered by the header path resolver unit test and the existing run API field path.Security Impact (required)
No)No)No)No)Yes, describe risk and mitigation: N/ACompatibility / Migration
Yes)No)No)Human Verification (required)
What was personally validated beyond CI:
working_pathvalue.Open in IDEbecause that would launch an external IDE on the local machine.Side Effects / Blast Radius (required)
working_pathwould fall back to the parent conversation cwd, preserving prior behavior.Rollback Plan (required)
d3901cbe.Risks and Mitigations
working_pathmay be unavailable on older or unusual run records.Summary by CodeRabbit
New Features
Tests