fix: correct response range bound in Paillier-DL ZK verification - #136
Merged
Conversation
The upper bound for the response z was computed as (q^2 + 1) * 2^SEC_P_STAT, which does not match the intended range. Use q^2 * (2^SEC_P_STAT + 1) so the check_right_open_range bound reflects the correct soundness range. Regenerate the accompanying spec/theory PDFs, which carry the following documentation updates (per each document's version history): - zk-proofs-spec: updated Fischlin protocols, ElGamal terminology, and verification checks; removed the dangling zk-proofs-macros.pdf dependency - zk-proofs-theory: corrected Batch-DL transcript hashing and updated the Valid-Paillier and PDL analyses - basic-primitives-spec/theory: added hybrid PKE via KEM/DEM - ecdsa-2pc-spec: fixed centered rounding for s' and completed the optional signing-proof flow - ec-dkg-spec: corrected threshold-share validation and updated dependencies - schnorr-spec: corrected the two-party signing figure and clarified the multiparty signing API and output receiver - constant-time: clarified masking and modular-inversion behavior and corrected the Secure Usage link These updates resolve all currently open issues: Fixes #7 Fixes #62 Fixes #133 Fixes #134
✅ Heimdall Review Status
|
hsiuhsiu
marked this pull request as ready for review
August 31, 2026 14:34
Arash-Afshar
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upper bound for the response z was computed as (q^2 + 1) * 2^SEC_P_STAT, which does not match the intended range. Use q^2 * (2^SEC_P_STAT + 1) so the check_right_open_range bound reflects the correct soundness range.
Regenerate the accompanying spec/theory PDFs, which carry the following documentation updates (per each document's version history):
These updates resolve all currently open issues:
Fixes #7
Fixes #62
Fixes #133
Fixes #134