docs: clarify ECDSA-2P scalar-detached blob is not public-only - #128
Merged
Merged
Conversation
…al- #462 Rename the misleading `public_key_blob` parameter/variable to `scalar_detached_key_blob` across the ECDSA-2PC C++ and C APIs, and document that `detach_private_scalar` does not produce public-only material: for P1 the detached blob still retains the Paillier private key and `c_key`, whose decryption recovers the private scalar. Callers must protect it exactly like the full P1 key blob. Update README.md and SECURE_USAGE.md with the corresponding guidance and adjust unit tests to the new naming.
✅ Heimdall Review Status
|
hsiuhsiu
changed the title
hsiuhsiu
marked this pull request as ready for review
August 4, 2026 15:56
Arash-Afshar
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the misleading
public_key_blobparameter/variable toscalar_detached_key_blobacross the ECDSA-2PC C++ and C APIs, and document thatdetach_private_scalardoes not produce public-only material: for P1 the detached blob still retains the Paillier private key andc_key, whose decryption recovers the private scalar. Callers must protect it exactly like the full P1 key blob.Update README.md and SECURE_USAGE.md with the corresponding guidance and adjust unit tests to the new naming.