fix: validate R1/R2 points are on curve in ECDSA2P - #125
Merged
Merged
Conversation
Explicitly check that received R2 (P1 side) and R1 (P2 side) points lie on the signing curve before using them in scalar multiplication, rather than relying on the ZK proof verify function to catch invalid points.
✅ Heimdall Review Status
|
hsiuhsiu
marked this pull request as ready for review
July 22, 2026 15:57
Arash-Afshar
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly check that received R2 (P1 side) and R1 (P2 side) points lie on the signing curve before using them in scalar multiplication, rather than relying on the ZK proof verify function to catch invalid points.