Repository navigation
fix: concurrent map writes panic - #20
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces thread-safety to the WorkloadHandler by adding a sync.RWMutex to protect the svids map from concurrent access. The feedback suggests using a value type for the mutex instead of a pointer to follow Go idioms, which also simplifies the struct initialization.
glindstedt
force-pushed
the
push-vkzuwtmlowrk
branch
from
April 7, 2026 13:56
bd1dc1a to
d2578cf
Compare
alec-w
self-requested a review
April 7, 2026 14:40
alec-w
approved these changes
Apr 7, 2026
alec-w
left a comment
alec-w
left a comment
Contributor
There was a problem hiding this comment.
Good catch!
Thanks @glindstedt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into a concurrent map write panic so added an RWMutex to use when accessing the map