Skip to content

Add support for MacOS - #15

Merged
mattbates merged 3 commits into
mainfrom
mb/support-darwin
Feb 20, 2026
Merged

mattbates merged 3 commits into
mainfrom
mb/support-darwin

Conversation

@mattbates

@mattbates mattbates commented Nov 23, 2025 •

Copy link
Copy Markdown
Contributor

Adds an implementation for Darwin and uses build flags.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @mattbates, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the spire-devserver package by enabling compatibility with MacOS. It achieves this by refactoring the core logic responsible for obtaining caller information (PID, UID, GID, and binary name) during gRPC handshakes, moving away from Linux-specific system calls to a more generalized approach. This change ensures that the server can correctly identify peer processes across different operating systems, alongside a routine update to a Go system-level dependency.

Highlights

  • MacOS Support: The pull request introduces support for MacOS by refactoring the peer credential retrieval logic to be platform-agnostic.
  • Platform-Agnostic Credential Retrieval: The Linux-specific syscall.GetsockoptUcred and /proc file system reading have been replaced with a new getCallerInfo function, abstracting the process for different operating systems.
  • Dependency Update: The golang.org/x/sys dependency has been updated from v0.35.0 to v0.38.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the gRPC server handshake logic to support multiple operating systems by abstracting platform-specific code into a getCallerInfo function. This is a good architectural choice for adding macOS support. However, the pull request is incomplete as it omits the implementation of this new function, which will cause a compilation failure. The update to the golang.org/x/sys dependency is also noted and seems appropriate for this kind of change.

Comment thread pkg/spire-devserver/grpc-authinfo.go
@mattbates
mattbates marked this pull request as draft November 23, 2025 20:57
@mattbates
mattbates marked this pull request as ready for review November 24, 2025 09:12
@mattbates mattbates added this to the now milestone Nov 24, 2025
@mattbates

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for MacOS by adding platform-specific implementations for retrieving caller information (PID, UID, GID, and BinaryName) for Unix domain socket connections. The core grpc-authinfo.go file has been refactored to delegate to these new platform-specific functions, improving modularity and maintainability. Dependency updates in go.mod and go.sum reflect the new libraries required for MacOS support. Overall, the changes are well-structured and achieve the stated goal.

Comment thread pkg/spire-devserver/grpc-authinfo-darwin.go
Comment thread pkg/spire-devserver/grpc-authinfo-darwin.go
Comment thread pkg/spire-devserver/grpc-authinfo-darwin.go

@sd109 sd109 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this locally on my Mac and it works well for me.

@mattbates
mattbates merged commit 7f0a2b1 into main Feb 20, 2026
1 check passed
@mattbates
mattbates deleted the mb/support-darwin branch February 20, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants