Gson upgrade to 2.13.2 2.29.x #6947
Open
+136
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leDateFormat for years below 2020 by replacing it with java.time.format.DateTimeFormatter and initialize test data in a test setup method to make sure that there's no CPU ticks between dates initializations.
|
|
Author
|
@alexabird could you please review this PR? |
clockard
approved these changes
Dec 30, 2025
derekwilhelm
reviewed
Jan 5, 2026
Comment on lines
619
to
620
| date = getDate(); | ||
| propertyIsEqualToWithDate = getPropertyIsEqualToWithDate(getDate()); |
Contributor
There was a problem hiding this comment.
❓ Why is getDate() called twice here? Should the date result from the first call just be passed into the getPropertyIsEqualToWithDate method?
derekwilhelm
approved these changes
Jan 7, 2026
Contributor
|
The target branch is codice:master - should it be updated to 2.29.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves CVEs with the current GSon version by upgrading to GSon 2.13.2
NOTE:
It has a dependency on country code changes in the following PR: codice/countrycode#37
Select relevant component teams:
Ask 2 committers to review/merge the PR and tag them here.
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: https://jira.irad-launchpad.com/browse/ISR-22364
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: