Merged
Conversation
EhabY
force-pushed
the
chore/pin-coder-v2.33.1-and-deps
branch
2 times, most recently
from
cb2f8fe to
9d7fd85
Compare
- Pin coder to github:coder/coder#v2.33.1 (was #main) for reproducible builds; document the tagging convention in CONTRIBUTING.md. - Bump axios, zod, eslint, typescript-eslint, jsdom, globals, @eslint-react/eslint-plugin, @tanstack/react-query, react, react-dom, vite to latest minors/patches. - Cast "agents" to Experiment in deploymentManager: the experiment string is not in the v2.33.1 Experiment union (added in v2.34.0-rc.0). Runtime behavior is unchanged.
web-api-no-leaked-fetch and jsx-no-leaked-dollar ship at warn level in v5's recommended-type-checked preset. They catch real bug classes (unaborted fetch in useEffect; accidentally-rendered template strings). Existing code passes both, so promote to error.
EhabY
force-pushed
the
chore/pin-coder-v2.33.1-and-deps
branch
from
9d7fd85 to
e1e36e7
Compare
matifali
reviewed
May 7, 2026
matifali
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github:coder/coder#v2.33.1(previously#main) so installs are reproducible and not re-fetched on everypnpm install.CONTRIBUTING.mdwith the new tag-pinning convention.axios,zod,eslint,typescript-eslint,jsdom,globals,@eslint-react/eslint-plugin,@tanstack/react-query,react,react-dom,vite.