Skip to content

chore(installer): remove WinHttpAutoProxySvc service dependency #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deansheather wants to merge 1 commit into from
+4 −3
Closed

chore(installer): remove WinHttpAutoProxySvc service dependency #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Installer/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,13 @@ private static int BuildMsiPackage(MsiOptions opts)
RestartServiceDelayInSeconds = 30,
ResetPeriodInDays = 1,
PreShutdownDelay = 1000 * 60 * 3, // default
// This matches Tailscale's service dependencies, with one omission: iphlpsvc. We do not
// use any of the IPv6 transition technologies provided by that service.
// This is based on Tailscale's service dependencies, with two omissions:
// - iphlpsvc: we do not use any of the IPv6 transition technologies provided by that service.
// - WinHttpAutoProxySvc: in our Tailscale fork, we've patched out the requirement on WPAD
// (WinHTTP Web Proxy Auto-Discovery), so we don't need to depend on this service.
DependsOn =
[
new ServiceDependency("netprofm"), // Network List Service
new ServiceDependency("WinHttpAutoProxySvc"), // WinHTTP Web Proxy Auto-Discovery Service
],
};
var shortcut = new FileShortcut("Coder Desktop", "%StartMenuFolder%")
Expand Down
Loading