Repository navigation
feat(web): redesign the Send a test email dialog - #119
Merged
Merged
Conversation
Address chips with a 1 of 5 counter, a From / Via / Subject summary, and an inline prompt to add the mailing address before a test can be sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the new Send a test email design for broadcasts and the sequence email editor.
[Test]tag. The callers now pass the subject.Tests
send-test-dialog.test.tsx: recipient parsing, chips and counter, the summary rows, and saving the mailing address inline. All web tests pass (93), along with lint and typecheck.