Skip to content

test: fix FirebaseAdapter encode test for unsupported algorithm#1341

Merged
datamweb merged 1 commit into
codeigniter4:developfrom
michalsn:fix/test-unsupported-alg
Jun 15, 2026
Merged

test: fix FirebaseAdapter encode test for unsupported algorithm#1341
datamweb merged 1 commit into
codeigniter4:developfrom
michalsn:fix/test-unsupported-alg

Conversation

@michalsn

Copy link
Copy Markdown
Member

Description
This PR fixes the FirebaseAdapter encode test, which broke because firebase/php-jwt now recognizes PS256 as supported (it just needs phpseclib).

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the testing Pull requests that changes tests only label Jun 15, 2026

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datamweb datamweb merged commit 8c0e7ec into codeigniter4:develop Jun 15, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants