test: add unit tests for Session BaseHandler - #10434
Open
gr8man wants to merge 2 commits into
Open
Conversation
gr8man
force-pushed
the
tests/add-basehandler-unit-tests
branch
from
July 31, 2026 18:31
90ed381 to
567af5d
Compare
Member
|
Thank you for your effort. Our testing guidelines recommend testing public behavior rather than protected or private implementation details, except when those internals are sufficiently complex to justify direct testing. Since these methods are simple, pursuing higher coverage here would add maintenance cost without meaningfully increasing confidence. For that reason, I don't think we should merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive unit tests for
system/Session/Handlers/BaseHandler.php, covering the constructor,lockSession(),releaseLock(),fail(),destroyCookie(), and theLoggerAwareTraitintegration.