refactor(HTTP): optimize file path parsing in download() method#10330
Open
gr8man wants to merge 1 commit into
Open
refactor(HTTP): optimize file path parsing in download() method#10330gr8man wants to merge 1 commit into
gr8man wants to merge 1 commit into
Conversation
…eme filename test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the file path parsing logic in the
ResponseTrait::download()method.What was changed and why:
explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename))array-based approach with PHP's nativebasename($filename)function. This reduces memory allocation (no array garbage collection) and is significantly faster (~4.5x faster in benchmarks).$filepathvariable and double conditionals by assigning directly to the constructor within the physical file path block. This reduces cognitive load and improves readability.testGetDownloadResponseByExtremeFilePathto unit tests to ensure thatbasename()securely and properly handles file names containing tricky symbols (e.g.,!@#$%) across different operating systems.Checklist: